Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 )
Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19521/1/source/snappy/build.sh File source/snappy/build.sh: http://gerrit.cloudera.org:8080/#/c/19521/1/source/snappy/build.sh@41 PS1, Line 41: fPIC Shouldn't we also mention the addition of the -fPIC flag in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/19521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52 Gerrit-Change-Number: 19521 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 22 Feb 2023 14:04:28 +0000 Gerrit-HasComments: Yes
