Hello Daniel Becker, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19521
to look at the new patch set (#2).
Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4
......................................................................
IMPALA-11927: Enable frame pointers for snappy and lz4
Adds the -fno-omit-frame-pointer flag while compiling snappy and lz4.
These two libs are used in many different code paths. In perf
investigation, the flame graphs make more sense with them enabled.
Tests:
- Ran perf test on TPCH. No significant perf change is detected.
Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52
---
M source/lz4/build.sh
M source/snappy/build.sh
2 files changed, 13 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/21/19521/2
--
To view, visit http://gerrit.cloudera.org:8080/19521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52
Gerrit-Change-Number: 19521
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
