Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19521 )
Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19521/1/source/snappy/build.sh File source/snappy/build.sh: http://gerrit.cloudera.org:8080/#/c/19521/1/source/snappy/build.sh@41 PS1, Line 41: fPIC > Shouldn't we also mention the addition of the -fPIC flag in the commit mess Thanks for catching this. I encountered link errors without -fPIC here. After digging more, I think I understand the reason. -fPIC is added in CFLAGS and CXXFLAGS exported by init-compiler.sh. As mentioned in the CMake doc, CXXFLAGS will be ignored if the CMAKE_CXX_FLAGS variable is defined. So we lose what we set in CXXFLAGS. I think the correct way of adding the new flag is by -DCMAKE_CXX_FLAGS="$CXXFLAGS -fno-omit-frame-pointer" It's strange that I didn't see link errors on liblz4. Anyway, I'll update the patch. https://cmake.org/cmake/help/v3.22/envvar/CXXFLAGS.html -- To view, visit http://gerrit.cloudera.org:8080/19521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52 Gerrit-Change-Number: 19521 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 13:03:46 +0000 Gerrit-HasComments: Yes
