Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 6: (11 comments) Thanks for the comments. http://gerrit.cloudera.org:8080/#/c/19776/5/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/19776/5/common/thrift/CatalogObjects.thrift@81 PS5, Line 81: } > I haven't found any usage for these new virtual columns. I'd bet they are f Done http://gerrit.cloudera.org:8080/#/c/19776/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/19776/5/common/thrift/Query.thrift@827 PS5, Line 827: DML op > It's not just INSERT anymore, right? (same below) Done http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@162 PS5, Line 162: > This comment is off now. Done http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@172 PS5, Line 172: } > is 'this.' needed here? Looks bit weird to me. Yes, 'this' is needed here as ModifyKudu and ModifyIceberg are inner classes. http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@174 PS5, Line 174: modifyImpl_ = this.new ModifyKudu(); > I believe this case is taken care by the check in L163. Done http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@362 PS5, Line 362: throws AnalysisException; > This function (and the one below) seems implementation specific and seems o Moved these methods back to the ModifyStmt. http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@466 PS5, Line 466: deleteCols = new String[] {"INPUT__FILE__NAME", "FILE__POSITION"}; > Could you please create a Jira for this and link it here? Done http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@482 PS5, Line 482: > As written in an above comment, having Kudu specific functions in this Iceb Done http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@300 PS5, Line 300: default boolean isPartitioned() { > for my information: This returns true even if the table is not partitioned Yes, maybe it could have a better name. isOrWasPartitiond()? :) Could be improved further to detect if there's partitioning in only the available snapshots. But I'm not sure if it worth the effort as it is probably a very rare situation when users make a partitioned table non-partitioned. http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@304 PS5, Line 304: if (partField.getTransformType() != TIcebergPartitionTransformType.VOID) { > nit: you can negate the condition here and return true instead of 'continue Thanks, done. http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java: http://gerrit.cloudera.org:8080/#/c/19776/5/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java@42 PS5, Line 42: it. > Technically Iceberg is not a file format. Would it break anything to remove Turns out I can remove this whole set. -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 14:57:16 +0000 Gerrit-HasComments: Yes
