Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 7: (4 comments) A few nits only http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@30 PS7, Line 30: import org.apache.commons.lang.NotImplementedException; unused I think http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@442 PS7, Line 442: "but the given table use a different file format: " + Nit "table uses a" http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java: http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java@26 PS7, Line 26: import org.apache.impala.catalog.HdfsFileFormat; Nit: HdfsFileFormat, IcebergPositionDeleteTable, ImmutableSet are unused http://gerrit.cloudera.org:8080/#/c/19776/7/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java@43 PS7, Line 43: private final static Logger LOG = LoggerFactory.getLogger(IcebergDeleteSink.class); Nit: unused -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 19 May 2023 20:13:56 +0000 Gerrit-HasComments: Yes
