Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 6: (4 comments) Thanks for the comments. PS6 was flawed, it raised NPE for all DELETE statements. http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@68 PS6, Line 68: > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java: http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java@36 PS6, Line 36: * Sink for deleting data from Iceberg tables. > nit: Could you extend this comment with a few sentence how iceberg handles Extended the comment. http://gerrit.cloudera.org:8080/#/c/19776/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test: http://gerrit.cloudera.org:8080/#/c/19776/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test@8 PS5, Line 8: Deelte > nit: Delete Done http://gerrit.cloudera.org:8080/#/c/19776/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test: http://gerrit.cloudera.org:8080/#/c/19776/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test@8 PS6, Line 8: Deelte > nit: Delete Done -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 13:50:37 +0000 Gerrit-HasComments: Yes
