Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 6: (4 comments) Great change Zoltan! Did a first round of review and testing, looks good, but I would like to do another round before giving a +1. Just a few nits and found a corner case. I was able to target a virtual column with delete statement and received a NPE. DELETE FROM ice_delete WHERE FILE__POSITION = 0; http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java File fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java: http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java@68 PS6, Line 68: nit: empty line http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java: http://gerrit.cloudera.org:8080/#/c/19776/6/fe/src/main/java/org/apache/impala/planner/IcebergDeleteSink.java@36 PS6, Line 36: * Sink for deleting data from Iceberg tables. nit: Could you extend this comment with a few sentence how iceberg handles deletes. Something like delete files will be inserted and these will be used in a join during scanning. http://gerrit.cloudera.org:8080/#/c/19776/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test: http://gerrit.cloudera.org:8080/#/c/19776/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test@8 PS5, Line 8: Deelte nit: Delete http://gerrit.cloudera.org:8080/#/c/19776/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test: http://gerrit.cloudera.org:8080/#/c/19776/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete.test@8 PS6, Line 8: Deelte nit: Delete -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 09:24:51 +0000 Gerrit-HasComments: Yes
