Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19763/4/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/4/www/query_plan.tmpl@288 PS4, Line 288: export_link.download = `${export_filename.value.replace(/\W/g,'_')}${export_format.value}`; Please make this substitution in the modal. It is prompting for a filename and showing : still which is confusing when it silently replaces afterwards. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 02 May 2023 15:38:42 +0000 Gerrit-HasComments: Yes
