Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc@311 PS2, Line 311: Unknown flags in JAVA_TOOL_OPTIONS causes Java to ignore everything, We could create a test that sets something basic in JAVA_TOOL_OPTIONS and verifies that the JVM actually has that option after startup? (Or modify an existing test to fail if the jvm option doesn't get through.) http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc@315 PS2, Line 315: if (java_home != NULL) { : cmd = (boost::filesystem::path(java_home) / "bin" / "java").string(); : } For my curiousity: Do our docker images find this via JAVA_HOME or PATH with this change? http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc@335 PS2, Line 335: if (std::stoi(matches.str(1)) < 9) return Status::OK(); Technically this can throw an exception if things go wrong. They shouldn't go wrong, but probably we should handle it anyway. -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 25 May 2023 23:43:24 +0000 Gerrit-HasComments: Yes
