Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc@315 PS2, Line 315: if (java_home != NULL) { : cmd = (boost::filesystem::path(java_home) / "bin" / "java").string(); : } > I added using PATH as a fallback because of the docker images. It's good to support falling back to PATH, but we can also export JAVA_HOME in docker/daemon_entrypoint.sh. http://gerrit.cloudera.org:8080/#/c/19939/2/be/src/common/init.cc@335 PS2, Line 335: if (std::stoi(matches.str(1)) < 9) return Status::OK(); > As in try/catch? I think a DCHECK also would, and we control the regex. I c Right, with our regex there shouldn't be an issue. We could limit the number of digits we support for java version to 3. i.e. ([0-9]{1,3}), then there shouldn't be any condition that would produce an exception. -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 31 May 2023 03:24:50 +0000 Gerrit-HasComments: Yes
