Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc@313 PS4, Line 313: string cmd = "java"; An alternative to this would be to take over creating the JVM ourselves using JNI_CreateJavaVM. Currently we rely on the HDFS C interface to do that for us. If we did it ourselves, we'd need to recreate some of the classpath logic and include LIBHDFS_OPTS. However HDFS calls JNI_CreateJavaVM with vm_args.ignoreUnrecognized=1, and LIBHDFS_OPTS gets transformed into vm_args.options. Using LIBHDFS_OPTS rather than JAVA_TOOL_OPTIONS would allow us to supply unknown parameters, and skip checking the Java version. http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh@276 PS4, Line 276: export JAVA_TOOL_OPTIONS="$JAVA11_OPTIONS ${JAVA_TOOL_OPTIONS-}" > Should we ignore these in java 8? It seems JAVA_TOOL_OPTIONS will be unusab Yeah, that would make sense. -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:18:19 +0000 Gerrit-HasComments: Yes
