Hello Quanlong Huang, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19939
to look at the new patch set (#5).
Change subject: IMPALA-11260: (Addendum) Add-opens in LIBHDFS_OPTS
......................................................................
IMPALA-11260: (Addendum) Add-opens in LIBHDFS_OPTS
If Java 8 detects unknown options in JAVA_TOOL_OPTIONS, it ignores the
whole string. Changes jvm_automatic_add_opens to update LIBHDFS_OPTS, as
it ignores individual unknown options when initializing the JVM.
Also adds add-opens flags for frontend tests.
test_no_inaccessible_objects detected this in a test run.
Testing:
- manually confirmed -agentlib and LIBHDFS_OPTS from impala-config.sh
options are present with both Java 8 and Java 11.
- promoted test_jvm_mem_tracking to run in all strategies, as it's fast
and ensures JAVA_TOOL_OPTIONS is honored.
Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf
---
M be/src/common/init.cc
M bin/run-all-tests.sh
M docker/daemon_entrypoint.sh
M tests/custom_cluster/test_jvm_mem_tracking.py
4 files changed, 46 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19939/5
--
To view, visit http://gerrit.cloudera.org:8080/19939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
