Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Add-opens in LIBHDFS_OPTS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc@313 PS4, Line 313: string cmd = "java"; > An alternative to this would be to take over creating the JVM ourselves usi Java 8 is the most commonly used JVM version right now, and keeping its JVM arguments unmodified is a nice property. I feel like this logic is doing what a calling script would have done if jvm_automatic_add_opens didn't exist. I think I prefer this approach to the unconditional approach. -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Jun 2023 18:27:04 +0000 Gerrit-HasComments: Yes
