Gergely Fürnstáhl has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier Partitioned Hash Join with a limit could hang when using mt_dop>0, due to the cyclic barrier in PHJBuilder is not cancelled properly. Added possibility to cancel the barrier with OK status and added the cancellation to PHJNode::Close(). Testing: - Added new unit tests covering OK cancelling - Added e2e test to make sure the join does not hang Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b --- M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc M be/src/util/cyclic-barrier-test.cc M be/src/util/cyclic-barrier.cc M be/src/util/cyclic-barrier.h M testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test 6 files changed, 57 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/20179/3 -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 3 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]>
