Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc File be/src/util/cyclic-barrier-test.cc: http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@190 PS4, Line 190: > nit: "Threads should not have returned", similar to the phrasing "should no Done http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@235 PS4, Line 235: } > No change here. Done -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 14 Jul 2023 08:29:56 +0000 Gerrit-HasComments: Yes
