Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/exec/partitioned-hash-join-node.cc@289 PS4, Line 289: if (ht_ctx_ != nullptr) { > The idea was to unblock the other threads asap, but I agree with your idea Done http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc File be/src/util/cyclic-barrier-test.cc: http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@168 PS4, Line 168: // All threads should join the barrier, waiting. > Oversight on my side, done Done http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@190 PS4, Line 190: > Done nit: "Threads should not have returned", similar to the phrasing "should not have run". http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@213 PS4, Line 213: thread_group threads; > Done Done http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@235 PS4, Line 235: } > Done No change here. http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/util/cyclic-barrier-test.cc@252 PS4, Line 252: threads.join_all(); > Done Done http://gerrit.cloudera.org:8080/#/c/20179/4/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test File testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test: http://gerrit.cloudera.org:8080/#/c/20179/4/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test@54 PS4, Line 54: select ss_cdemo_sk from tpcds.store_sales where ss_sold_date_sk = (select max(ss_sold_date_sk) from tpcds.store_sales) group by ss_cdemo_sk limit 3; > Done Done -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 13 Jul 2023 20:15:18 +0000 Gerrit-HasComments: Yes
