Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/20179/4/be/src/exec/partitioned-hash-join-node.cc@289 PS4, Line 289: if (builder_ && builder_->probe_barrier()) builder_->probe_barrier()->Unregister(); > I guess the number of remaining transitions for other threads could be unpr nit: it might be a little safer to unregister after other builder_ operations (lines 303-311) to avoid breakage in the future. Is there some reason to do it earlier? -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 13 Jul 2023 18:06:48 +0000 Gerrit-HasComments: Yes
