Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20181 )

Change subject: IMPALA-12275: Read files written with DeflateCodec
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20181/1/be/src/util/codec.cc
File be/src/util/codec.cc:

http://gerrit.cloudera.org:8080/#/c/20181/1/be/src/util/codec.cc@59
PS1, Line 59:     {DEFLATE_COMPRESSION, THdfsCompression::DEFAULT},
> I should be able to create a test case for this, just haven't figured it ou
Done


http://gerrit.cloudera.org:8080/#/c/20181/2/tests/custom_cluster/test_hive_sequence_codec_interop.py
File tests/custom_cluster/test_hive_sequence_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/20181/2/tests/custom_cluster/test_hive_sequence_codec_interop.py@18
PS2, Line 18: text
> nit. a nit? maybe sequence
Done



--
To view, visit http://gerrit.cloudera.org:8080/20181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ec1d0345ae35597f6aade9d8b9eef2257efeba
Gerrit-Change-Number: 20181
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 11 Jul 2023 16:41:09 +0000
Gerrit-HasComments: Yes

Reply via email to