Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20181 )
Change subject: IMPALA-12275: Read files written with DeflateCodec ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_sequence_codec_interop.py File tests/custom_cluster/test_hive_sequence_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_sequence_codec_interop.py@34 PS3, Line 34: CustomClusterTestSuite > Not your change, but I'm not sure why these are custom cluster tests rather I'll look into a little refactoring. http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_text_codec_interop.py File tests/custom_cluster/test_hive_text_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_text_codec_interop.py@30 PS3, Line 30: 'deflate' > Was deflate already working for text? i.e. the bug was specific to sequence Yes. It looks like text had specifically patched for this in https://github.com/apache/impala/blob/master/be/src/exec/text/hdfs-text-scanner.cc#L235-L237. I'm going to look at removing the text-specific patch in favor of this general patch, and I'll add some more explanation to the patch. -- To view, visit http://gerrit.cloudera.org:8080/20181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5ec1d0345ae35597f6aade9d8b9eef2257efeba Gerrit-Change-Number: 20181 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 18:26:10 +0000 Gerrit-HasComments: Yes
