Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20181 )
Change subject: IMPALA-12275: Read files written with DeflateCodec ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py File tests/query_test/test_hive_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@a61 PS4, Line 61: source_table = "{0}.{1}".format(unique_database, "t1_source") This tested that Hive could read a textfile written by Impala. But it didn't test any particular compression, so that didn't seem very useful. http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@50 PS4, Line 50: ImpalaTestSuite > TestFileCodecInterop? That makes more sense. I misunderstood the super call, and calling super(TestFileCodecInterop, cls).add_test_dimensions fails because it's not defined on ImpalaTestSuite. Not sure why this one works. http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@68 PS4, Line 68: > nit. unnecessary newline? I liked the formatting better, but I can remove it. http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@109 PS4, Line 109: > nit. unnecessary newline? Ack http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@112 PS4, Line 112: TestFileCodecInterop > TestTextInterop Ah, I misunderstood this call. http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@123 PS4, Line 123: > nit. unnecessary newline? Ack http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@126 PS4, Line 126: TestFileCodecInterop > TestSequenceInterop Ack http://gerrit.cloudera.org:8080/#/c/20181/4/tests/query_test/test_hive_codec_interop.py@129 PS4, Line 129: @pytest.mark.execute_serially > I think we can remove this Ack -- To view, visit http://gerrit.cloudera.org:8080/20181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5ec1d0345ae35597f6aade9d8b9eef2257efeba Gerrit-Change-Number: 20181 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 18:05:43 +0000 Gerrit-HasComments: Yes
