Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20181 )
Change subject: IMPALA-12275: Read files written with DeflateCodec ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_sequence_codec_interop.py File tests/custom_cluster/test_hive_sequence_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_sequence_codec_interop.py@34 PS3, Line 34: > I'll look into a little refactoring. Done http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_sequence_codec_interop.py@58 PS3, Line 58: > Nit: Since this test function is so similar to the test_hive_text_codec_int Done http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_text_codec_interop.py File tests/custom_cluster/test_hive_text_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/20181/3/tests/custom_cluster/test_hive_text_codec_interop.py@30 PS3, Line 30: > Yes. It looks like text had specifically patched for this in https://github hdfs-text-scanner.cc code is for a slightly different case (THdfsCompression::DEFLATE) where-as DefaultCodec/DeflateCodec map to THdfsCompression::DEFAULT. -- To view, visit http://gerrit.cloudera.org:8080/20181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5ec1d0345ae35597f6aade9d8b9eef2257efeba Gerrit-Change-Number: 20181 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 21:30:40 +0000 Gerrit-HasComments: Yes
