Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier-test.cc File be/src/util/cyclic-barrier-test.cc: http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier-test.cc@205 PS6, Line 205: Test that unregister functions as expected. This is the same comment as above. Could you please add some details to them? http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.h File be/src/util/cyclic-barrier.h: http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.h@86 PS6, Line 86: execute 'fn' nit: execute 'fn' of Wait() http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.cc File be/src/util/cyclic-barrier.cc: http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.cc@41 PS6, Line 41: std::unique_lock<std::mutex> l(lock_); nit: no need for 'std::' http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.cc@44 PS6, Line 44: DCHECK(num_threads_ >= 0); nit: could be DCHECK_GE http://gerrit.cloudera.org:8080/#/c/20179/6/be/src/util/cyclic-barrier.cc@47 PS6, Line 47: if (notify) { : barrier_cv_.NotifyOne(); : } nit: fits single line -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 6 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:05:53 +0000 Gerrit-HasComments: Yes
