Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@859 PS6, Line 859: List<RuntimeFilter> incomingFilters = runtimeFilt > What happens if other nodes also have predicates? An example that comes to Latest patch set will not reduce runtime filter if it detects that the build fragment has PlanNode other than ScanNode and UnionNode. Added some more test cases in bloom-filter-assignment.test. -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 05 Sep 2023 15:14:23 +0000 Gerrit-HasComments: Yes
