Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 )
Change subject: IMPALA-12430: Skip compression when sending row batches within same process ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc@211 PS2, Line 211: const NetworkAddressPB& GetAddress() { return address_; }; declare method const http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc@806 PS2, Line 806: bool is_local = channels_.size() == 1 Can Channels::is_local flag be used here instead of re-computing? http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc@277 PS2, Line 277: if (size > 0 && !output_batch->skip_compression_) { Is there any accounting for compression memory in the resource profile that should b changed to reflect this optimization? -- To view, visit http://gerrit.cloudera.org:8080/20462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea23fd1f0f10f72f3dbd8594f3def3ee190230a Gerrit-Change-Number: 20462 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 20:04:14 +0000 Gerrit-HasComments: Yes
