Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 )
Change subject: IMPALA-12430: Skip compression when sending row batches within same process ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20462/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20462/3//COMMIT_MSG@16 PS3, Line 16: is > Nit: is. Done http://gerrit.cloudera.org:8080/#/c/20462/3//COMMIT_MSG@26 PS3, Line 26: > Nit: 'of' seems unnecessary here. Done http://gerrit.cloudera.org:8080/#/c/20462/3/be/src/runtime/outbound-row-batch.h File be/src/runtime/outbound-row-batch.h: http://gerrit.cloudera.org:8080/#/c/20462/3/be/src/runtime/outbound-row-batch.h@39 PS3, Line 39: =false > I missed the tests and benchmarks, they're not updated there. Still I'd con I was considering updating the benchmarks as ideally compression could be added is a new dimension but wanted to keep this change minimal. http://gerrit.cloudera.org:8080/#/c/20462/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/20462/6/tests/query_test/test_observability.py@504 PS6, Line 504: assert "ExchangeScanRatio: 4.63" in profile Running all tests revealed that this was broken by the change. -- To view, visit http://gerrit.cloudera.org:8080/20462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea23fd1f0f10f72f3dbd8594f3def3ee190230a Gerrit-Change-Number: 20462 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 12:39:57 +0000 Gerrit-HasComments: Yes
