Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 )
Change subject: IMPALA-12430: Skip compression when sending row batches within same process ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc@211 PS2, Line 211: bool IsLocal() const { return is_local_; } > declare method const Property no longer needed after resolving other comment. http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/krpc-data-stream-sender.cc@806 PS2, Line 806: bool is_local = channels_.size() == 1 && channels_[0]->IsLocal(); > Can Channels::is_local flag be used here instead of re-computing? Done http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc@277 PS2, Line 277: if (size > 0 && !output_batch->skip_compression_) { > Is there any accounting for compression memory in the resource profile that I would prefer to decrease the reservation in a later patch I think that it would be possible to work with much fewer buffers, created a ticket for this: IMPALA-12433 Doing that optimization would allow lowering mem estimates significantly. -- To view, visit http://gerrit.cloudera.org:8080/20462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea23fd1f0f10f72f3dbd8594f3def3ee190230a Gerrit-Change-Number: 20462 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 11:42:33 +0000 Gerrit-HasComments: Yes
