Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 )
Change subject: IMPALA-12430: Skip compression when sending row batches within same process ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20462/3/be/src/runtime/outbound-row-batch.h File be/src/runtime/outbound-row-batch.h: http://gerrit.cloudera.org:8080/#/c/20462/3/be/src/runtime/outbound-row-batch.h@39 PS3, Line 39: =false > The default value is not needed, all call sites have been updated to pass t I missed the tests and benchmarks, they're not updated there. Still I'd consider updating those call sites so it is more explicit that there is a second parameter. -- To view, visit http://gerrit.cloudera.org:8080/20462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea23fd1f0f10f72f3dbd8594f3def3ee190230a Gerrit-Change-Number: 20462 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 12:09:33 +0000 Gerrit-HasComments: Yes
