Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 )
Change subject: IMPALA-12430: Skip compression when sending row batches within same process ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/20462/2/be/src/runtime/row-batch.cc@277 PS2, Line 277: if (size > 0 && !output_batch->skip_compression_) { > I would prefer to decrease the reservation in a later patch Ok. Please make to prioritize that. Reducing memory requirements is more important than improving performance in many cases. -- To view, visit http://gerrit.cloudera.org:8080/20462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea23fd1f0f10f72f3dbd8594f3def3ee190230a Gerrit-Change-Number: 20462 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Sep 2023 13:32:59 +0000 Gerrit-HasComments: Yes
