Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20469 )
Change subject: IMPALA-12436: Create multi-platform builder images ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py File docker/buildall.py: http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py@29 PS2, Line 29: # apt install binfmt-support qemu-user-static qemu-system-x86 : # then create a docker-container builder : # docker buildx create --use > Nit: Is there anything we can do to detect if these are appropriately speci I think the errors you get from Docker are pretty clear. These are only required if specifying '--multi', I'll update the comment to clarify that. I made sure most local development workflows would not require QEMU or a new builder, so these should only be needed if testing out multi-platform builds specifically. http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py@32 PS2, Line 32: 'redhat8' > Should we include redhat9? We could if we think we'll move CDW to it sometime soon. I was mostly trying to keep native-toolchain build varieties down to ones we would use. http://gerrit.cloudera.org:8080/#/c/20469/2/jenkins/build.sh File jenkins/build.sh: http://gerrit.cloudera.org:8080/#/c/20469/2/jenkins/build.sh@65 PS2, Line 65: popd > Something we could do to make sure we only push if all images succeeded is Done -- To view, visit http://gerrit.cloudera.org:8080/20469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I058deb877f26b48a2d87a65710143bba9a42a5fb Gerrit-Change-Number: 20469 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 11 Sep 2023 21:12:04 +0000 Gerrit-HasComments: Yes
