Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20469 )
Change subject: IMPALA-12436: Create multi-platform builder images ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/20469/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20469/5//COMMIT_MSG@17 PS5, Line 17: Moves the publishing step to happen within buildx, because buildx does : not support loading multi-platform images in the local Docker registry. : This does mean that a build failure could result in publishing only some : of the images. These are not updated frequently and are usually preceded : by a test run, so this risk seems minimal. > Can you update this to describe how we avoid this problem with the two pass Done http://gerrit.cloudera.org:8080/#/c/20469/5/docker/README.md File docker/README.md: http://gerrit.cloudera.org:8080/#/c/20469/5/docker/README.md@45 PS5, Line 45: and > Nit: and Done http://gerrit.cloudera.org:8080/#/c/20469/5/docker/buildall.py File docker/buildall.py: http://gerrit.cloudera.org:8080/#/c/20469/5/docker/buildall.py@58 PS5, Line 58: build_cmd += ['--builder', args.builder] > Does that impact the x86 single-arch build? Or is that basically fine becau I think it only impacts when you use a docker-container builder (for multi-platform builds), the default "docker" builder works fine. -- To view, visit http://gerrit.cloudera.org:8080/20469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I058deb877f26b48a2d87a65710143bba9a42a5fb Gerrit-Change-Number: 20469 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 12 Sep 2023 17:09:07 +0000 Gerrit-HasComments: Yes
