Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20469 )

Change subject: IMPALA-12436: Create multi-platform builder images
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20469/5/jenkins/build.sh
File jenkins/build.sh:

http://gerrit.cloudera.org:8080/#/c/20469/5/jenkins/build.sh@59
PS5, Line 59: ./buildall.py --multi --builder=${BUILDER} ${DISTRO_PARAM}
> Would it make sense to have an environment variable / Jenkins parameter tha
I didn't think so, but I'm open to adding it.

If you push to a registry, then we want to build with multi. If you don't, then 
we don't really need the output. Main scenario might be to test building a 
single platform, but if you want to test that without multi it's easy enough to 
do locally.



--
To view, visit http://gerrit.cloudera.org:8080/20469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I058deb877f26b48a2d87a65710143bba9a42a5fb
Gerrit-Change-Number: 20469
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 12 Sep 2023 17:05:07 +0000
Gerrit-HasComments: Yes

Reply via email to