Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20469 )

Change subject: IMPALA-12436: Create multi-platform builder images
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py
File docker/buildall.py:

http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py@29
PS2, Line 29: #   apt install binfmt-support qemu-user-static qemu-system-x86
            : # then create a docker-container builder
            : #   docker buildx create --use
> I think the errors you get from Docker are pretty clear. These are only req
Yeah, the normal path is fine, so it's only the --multi path that would be a 
problem. I noticed that we have a README.md file in this directory with some 
instructions for building the docker images. Maybe we could add a section there 
about what to install, how to get a builder, how to invoke buildall.py?


http://gerrit.cloudera.org:8080/#/c/20469/2/docker/buildall.py@32
PS2, Line 32: 'redhat8'
> We could if we think we'll move CDW to it sometime soon. I was mostly tryin
I agree that we don't really need Redhat 9 ARM at the moment, so even if we 
produce the docker images, we can probably skip the full build until later.



--
To view, visit http://gerrit.cloudera.org:8080/20469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I058deb877f26b48a2d87a65710143bba9a42a5fb
Gerrit-Change-Number: 20469
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Mon, 11 Sep 2023 21:34:20 +0000
Gerrit-HasComments: Yes

Reply via email to