Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 )
Change subject: IMPALA-12312: Using correct executor group set info for planning ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/20273/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/20273/4/be/src/scheduling/admission-controller.cc@1634 PS4, Line 1634: VLOG_QUERY << "AdmissionController::ResolvePoolAndGetConfig resolved pool " << *pool_name; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20273/4/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20273/4/be/src/scheduling/cluster-membership-mgr.cc@708 PS4, Line 708: << boost::algorithm::join(group_sets, ",") << " Current executor groups: " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20273/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20273/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2150 PS4, Line 2150: setGroupNamePrefix(default_executor_group_only, clientSetRequestPool, req, group_set); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20273/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2207 PS4, Line 2207: if (!default_executor_group_only && !group_set.getExec_group_name_prefix().isEmpty()) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20273/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2235 PS4, Line 2235: setGroupNamePrefix(default_executor_group_only, clientSetRequestPool, req, group_set); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20273/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2290 PS4, Line 2290: if (!default_executor_group_only && !group_set.getExec_group_name_prefix().isEmpty()) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80 Gerrit-Change-Number: 20273 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 19 Sep 2023 10:18:35 +0000 Gerrit-HasComments: Yes
