Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 )
Change subject: IMPALA-12312: Using correct executor group set info for planning ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc@671 PS6, Line 671: // Add a default exec group set if no expected group sets were specified. : exec_group_sets.emplace_back(); : exec_group_sets.back().__set_expected_num_executors(FLAGS_num_expected_executors); > Can we double check what is Impala rules on executor group sets configurati AFAIK, Impala does allow users to configure a 'default' EG and other EGs in a cluster. Yes, the 'default' EG here is just a fallback. If REQUEST_POOL query option is set to a non-existent pool(misconfiguration or some EG sets have been destroyed for auto-scaling), the coordinator should schedule this query on the 'default' group: https://github.com/apache/impala/blob/4d15558b5eaa69e872917c8bbf69dc1dc2146bc5/be/src/scheduling/admission-controller.cc#L2603-L2608. -- To view, visit http://gerrit.cloudera.org:8080/20273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80 Gerrit-Change-Number: 20273 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 13:36:09 +0000 Gerrit-HasComments: Yes
