Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 )
Change subject: IMPALA-12312: Using correct executor group set info for planning ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc@671 PS6, Line 671: // Add a default exec group set if no expected group sets were specified. : exec_group_sets.emplace_back(); : exec_group_sets.back().__set_expected_num_executors(FLAGS_num_expected_executors); Can we double check what is Impala rules on executor group sets configuration? If I remember correctly, Impala support either of 1 executor group set mode (only "default" EG), or multiple executor group set mode (which should should not contain "default" EG?). Is "default" EG added here only as a fallback if no expected group sets were specified (misconfiguration)? http://gerrit.cloudera.org:8080/#/c/20273/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20273/6/fe/src/main/java/org/apache/impala/service/Frontend.java@1974 PS6, Line 1974: e.getExec_group_name_prefix() == null : || e.getExec_group_name_prefix().isEmpty() Wrap this into a function? static boolean isDefaultExecGroupSet(TExecutorGroupSet e) { return StringUtils.isEmpty(e.getExec_group_name_prefix()); } -- To view, visit http://gerrit.cloudera.org:8080/20273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80 Gerrit-Change-Number: 20273 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 20 Sep 2023 16:30:21 +0000 Gerrit-HasComments: Yes
