Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20273
to look at the new patch set (#6).
Change subject: IMPALA-12312: Using correct executor group set info for planning
......................................................................
IMPALA-12312: Using correct executor group set info for planning
Prior to this patch, planner always selects the default group if there
is a default group in an impala cluster. When a client sets a
non-default request pool, planner still assumes the query run on the
default group and calculates the wrong number of nodes and instances.
This patch fixes it by including both default and non-default groups
in the update message sent from BE to FE, so planner can generate a
plan based on correct executor group set info. Besides, if no matched
executor group is found, planner falls back to using the default group
for planning, which is consistent with BE's behavior in
GetExecutorGroupsForQuery.
Tests:
- Add new test cases to ClusterMembershipMgrUnitTest.
- Add e2e test to verify the new behavior of planner.
Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80
---
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/custom_cluster/test_executor_groups.py
5 files changed, 165 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/20273/6
--
To view, visit http://gerrit.cloudera.org:8080/20273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80
Gerrit-Change-Number: 20273
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
