Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Basic unicode column name bug fix ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20506/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20506/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12465: Basic unicode column name bug fix nit: Don't need to call out that it's "Basic" http://gerrit.cloudera.org:8080/#/c/20506/2//COMMIT_MSG@9 PS2, Line 9: Impala primarily depends on hive functions for column name nit: "primarily" implies there are other methods. Can you be more specific? Like "Impala depends on Hive functions and <function?> for column name validation." http://gerrit.cloudera.org:8080/#/c/20506/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/20506/2/be/src/runtime/coordinator.cc@1172 PS2, Line 1172: const RPCErrorInfoPB& rpc_error_info = aux_error.rpc_error_info(); I'm confused why this is part of the patch. To avoid a conflict instead of rebasing? http://gerrit.cloudera.org:8080/#/c/20506/2/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: http://gerrit.cloudera.org:8080/#/c/20506/2/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java@207 PS2, Line 207: if (!MetaStoreUtils.validateColumnName(colName_)) { Can you call out in the commit message the difference between MetaStoreUtils.validateColumnName and MetastoreShim.validateName? We're using both. Do we still need MetastoreShim.validateName? Is MetaStoreUtils.validateColumnName available with USE_APACHE_HIVE? -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2023 17:40:59 +0000 Gerrit-HasComments: Yes
