Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 )
Change subject: IMPALA-12312: Using correct executor group set info for planning ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20273/6/be/src/scheduling/cluster-membership-mgr.cc@671 PS6, Line 671: // Add a default exec group set if no expected group sets were specified. : exec_group_sets.emplace_back(); : exec_group_sets.back().__set_expected_num_executors(FLAGS_num_expected_executors); > This sounds like a behavior change to me. I believe Impala now, correctly, Agree with Riza. We only add 'default' EG if expected EGs are not set. -- To view, visit http://gerrit.cloudera.org:8080/20273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80 Gerrit-Change-Number: 20273 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2023 21:23:56 +0000 Gerrit-HasComments: Yes
