Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 )
Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@281 PS5, Line 281: for (var instance = 1; instance < fp.child_profiles.length; ++instance) { Is is always the last event(s) that are missing? If so, we may not need to check labels. -- To view, visit http://gerrit.cloudera.org:8080/20522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025b00d8632a5a1953ecdaaa7d8a4ae224dd2610 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2023 14:28:01 +0000 Gerrit-HasComments: Yes
