Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 )
Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@281 PS5, Line 281: for (var instance = 1; instance < fp.child_profiles.length; ++instance) { > In one of the instances mentioned in IMPALA-12473, intermediate event times It might better to consolidate the 2 cases so that the labels are only checked while missing labels are not accounted for. Could even go last to first to optimize for the case where the last events are missing. http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@300 PS5, Line 300: continue; remove the continue and change the next branch to else if. http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@308 PS5, Line 308: ++i; factor ++i out of branches -- To view, visit http://gerrit.cloudera.org:8080/20522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025b00d8632a5a1953ecdaaa7d8a4ae224dd2610 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2023 16:42:11 +0000 Gerrit-HasComments: Yes
