Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 )
Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@281 PS5, Line 281: for (var instance = 1; instance < fp.child_profiles.length; ++instance) { > It might better to consolidate the 2 cases so that the labels are only chec >From what was encountered in the profiles, there was no such order, such as >the last event timestamps missing more. There were even cases where the first >event timestamps were missing. Could you please elaborate on which 2 cases >should be consolidated? http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@300 PS5, Line 300: continue; > remove the continue and change the next branch to else if. Done http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@308 PS5, Line 308: ++i; > factor ++i out of branches Done -- To view, visit http://gerrit.cloudera.org:8080/20522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025b00d8632a5a1953ecdaaa7d8a4ae224dd2610 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 16:47:17 +0000 Gerrit-HasComments: Yes
