Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 )
Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20522/2/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/2/www/query_timeline.tmpl@294 PS2, Line 294: if (fevents[i].no_bar) continue; > increase 'i', otherwise infinite loop. Also increase 'en' if two labels equ Sorry, I must have missed it because of using for-loop before. Done. http://gerrit.cloudera.org:8080/#/c/20522/2/www/query_timeline.tmpl@828 PS2, Line 828: www/profiles/q14a_json_profile. > why make this change? Done. http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/5/www/query_timeline.tmpl@281 PS5, Line 281: for (var instance = 1; instance < fp.child_profiles.length; ++instance) { > Is is always the last event(s) that are missing? If so, we may not need to In one of the instances mentioned in IMPALA-12473, intermediate event timestamps have been missing. So, I think verifying labels would be necessary. -- To view, visit http://gerrit.cloudera.org:8080/20522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025b00d8632a5a1953ecdaaa7d8a4ae224dd2610 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2023 17:54:44 +0000 Gerrit-HasComments: Yes
