Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 )
Change subject: IMPALA-12493: Allow retry after failed cancel_query ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/client-request-state.cc@229 PS4, Line 229: RETURN_IF_CANCELLED(this); > Does this fix another issue? If so, it'd be nice if we have test coverage f It was originally added in a patch where I allowed cancelling a query in CREATED state (but it wouldn't finish cancelling until the query completed its preparation). However I see other ways a query might get cancelled, and those could now succeed. I'll poke around and figure out how to add some tests. I also think we should disable the Cancel button in the UI if we know it's going to fail. http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/impala-server.cc@a1753 PS4, Line 1753: > Is it correct to skip this inflight check? I suppose I could simplify this patch a bit by also lifting the inflight check here. I'm not sure when it could be triggered. -- To view, visit http://gerrit.cloudera.org:8080/20584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24 Gerrit-Change-Number: 20584 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2023 17:59:16 +0000 Gerrit-HasComments: Yes
