Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20692 )

Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager
......................................................................


Patch Set 9:

> Patch Set 4:
>
> Running an AB test to see if this impacts x86 performance: 
> https://jenkins.impala.io/job/perf-AB-test-ub2004/20/

This actually showed a slight improvement in performance:
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format           | Avg (s) | Delta(Avg) | GeoMean(s) | 
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(42) | parquet / none / none | 3.13    | -2.51%     | 2.36       | -2.50% 
        |
+----------+-----------------------+---------+------------+------------+----------------+


--
To view, visit http://gerrit.cloudera.org:8080/20692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675
Gerrit-Change-Number: 20692
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Fri, 10 Nov 2023 18:02:53 +0000
Gerrit-HasComments: No

Reply via email to