Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/20692/11/be/src/thirdparty/llvm/SectionMemoryManager.cpp File be/src/thirdparty/llvm/SectionMemoryManager.cpp: http://gerrit.cloudera.org:8080/#/c/20692/11/be/src/thirdparty/llvm/SectionMemoryManager.cpp@47 PS11, Line 47: uintptr_t RequiredCodeSize = requiredSize(CodeSize, CodeAlign); The main difference between this patch and https://github.com/llvm/llvm-project/pull/71968 currently is that the LLVM PR handles multiple calls to reserveAllocationSpace on the same MemoryManager. We don't use that because - with MCJIT - it would only happen through calls to addObjectFile. It needs a little adaptation as llvm#main adds a new Align class. I guess I'll bring it over though. -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 17:54:15 +0000 Gerrit-HasComments: Yes
