Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc File be/src/codegen/mcjit-mem-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc@49 PS4, Line 49: > I did check the comments, but I didn't find anything that would rule out th Done http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc@93 PS4, Line 93: : : : : : : : : : : : : > Thanks for splitting the commit! Done -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 17:15:27 +0000 Gerrit-HasComments: Yes
