Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20695 )
Change subject: IMPALA-12495: Describe statement for Iceberg metadata tables ...................................................................... Patch Set 5: (2 comments) Left some minor comments, otherwise the change LGTM! http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@96 PS5, Line 96: if (IcebergMetadataTable.isIcebergMetadataTable(rawPath_)) { : analyzeIcebergMetadataTable(analyzer); : } Would it be possible to move 'isIcebergMetadataTable(rawPath_)' and 'analyzer.addMetadataVirtualTable(rawPath_)' to 'Analyzer.resolvePath()'? And in this method we would just have the Iceberg-specific checks after 'table_ = path_.getRootTable()'? http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/service/Frontend.java@1664 PS5, Line 1664: params.result_struct Should we add precondition check that this is set? -- To view, visit http://gerrit.cloudera.org:8080/20695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe22f271a59a6885035991c09b5101193ade6e97 Gerrit-Change-Number: 20695 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 12:31:53 +0000 Gerrit-HasComments: Yes
