Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions ......................................................................
Patch Set 5: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4419/5/tests/comparison/query_generator.py File tests/comparison/query_generator.py: Line 1436: if self.profile.only_use_equality_join_predicates(): I don't think this whole patch is necessary. We just need only_use_equality_join_predicates to always be true. This can be done by setting this probability http://github.mtv.cloudera.com/CDH/Impala/blob/cdh5-trunk/tests/comparison/query_profile.py#L220 to 1. -- To view, visit http://gerrit.cloudera.org:8080/4419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
