Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/4011/7/tests/comparison/cluster.py File tests/comparison/cluster.py: Line 185: other_conf_dir = os.environ["HIVE_CONF_DIR"] > I run the Hive tests against a local instance of Hive, so setting this to H ok, what do you think about creating a new HiveMiniCluster object that inherits from MiniCluster (or maybe even directly from the Cluster class?) and making changes to it? http://gerrit.cloudera.org:8080/#/c/4011/10/tests/comparison/data_generator.py File tests/comparison/data_generator.py: Line 156: elif self.db_engine is db_connection.HIVE: An exception should be raised if db_engine is not Impala or Hive. http://gerrit.cloudera.org:8080/#/c/4011/10/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 792: class HiveCursor(ImpalaCursor): Is this class being used anywhere? I think you want to override _CURSOR_CLASS in HiveConnection and specify this class there. Line 815: def cursor(self): What is the point of overriding the cursor method here? It does exactly the same thing the cursor method in the parent class. -- To view, visit http://gerrit.cloudera.org:8080/4011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: stak...@cloudera.com Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: stak...@cloudera.com Gerrit-HasComments: Yes
