Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3980: qgen: re-enable Hive as a target database
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4011/11/tests/comparison/cluster.py
File tests/comparison/cluster.py:

Line 211: class MiniHiveCluster(MiniCluster):
Nice.


http://gerrit.cloudera.org:8080/#/c/4011/11/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

Line 816:   def cursor(self):
What's the point of overriding this method? It does the same thing as the 
method in the parent class?


-- 
To view, visit http://gerrit.cloudera.org:8080/4011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stak...@cloudera.com
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: stak...@cloudera.com
Gerrit-HasComments: Yes

Reply via email to